Add optional parameters to PackagePush for chart version and appVersion#69
Closed
frizzr wants to merge 4 commits into
Closed
Add optional parameters to PackagePush for chart version and appVersion#69frizzr wants to merge 4 commits into
frizzr wants to merge 4 commits into
Conversation
frizzr
changed the title
Member
|
@frizzr This are good extensions, thank you. Could you please add tests for the new methods and parameters inside |
frizzr
force-pushed
the
rhfc-add-chart-version-opt
branch
from
2f1589e to
d9e62ab
Compare
Contributor
Author
|
I am going to close this PR in favor of #70. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very often a Helm chart version and appVersion are decided by CI automation, so this PR will provide optional parameters to the PackagePush function.
I also added two new public methods
NameandAppVersionthat complements theVersionpublic method and makes unit tests a bit easier. If you would rather not add those, they could be moved to the unit test package.